Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Ets values, operations, visitors #249

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Refactor Ets values, operations, visitors #249

merged 3 commits into from
Aug 2, 2024

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Aug 2, 2024

This PR introduces some improvements in the design of Ets operations (enums are replaced with classes) and also simplifies EtsValue visitors (merge visitors for Immediate, Constant, Ref into one).

In addition, the type of EtsIfStmt.condition was changed from EtsConditionExpr to EtsEntity, since JS/TS allows "implicit" constructions such as if (x) {...}. See also: https://gitee.com/openharmony-sig/arkanalyzer/issues/IAHIJ5

@Lipen Lipen requested a review from CaelmBleidd August 2, 2024 09:36
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 54s ⏱️ -1s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 68038a1. ± Comparison against base commit 133474f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Test results on JDK 19

   83 files  ±0     83 suites  ±0   27m 39s ⏱️ + 2m 7s
2 511 tests ±0  2 469 ✅ ±0  42 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 497 ✅ ±0  42 💤 ±0  0 ❌ ±0 

Results for commit 68038a1. ± Comparison against base commit 133474f.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 12.13873% with 304 lines in your changes missing coverage. Please review.

Project coverage is 59.41%. Comparing base (133474f) to head (68038a1).

Files Patch % Lines
...ets/src/main/kotlin/org/jacodb/ets/base/EtsExpr.kt 10.28% 218 Missing ⚠️
...rc/main/kotlin/org/jacodb/ets/utils/GetOperands.kt 0.00% 38 Missing ⚠️
...-ets/src/main/kotlin/org/jacodb/ets/dto/Convert.kt 32.65% 30 Missing and 3 partials ⚠️
...ts/src/main/kotlin/org/jacodb/ets/base/EtsValue.kt 0.00% 14 Missing ⚠️
...s/src/main/kotlin/org/jacodb/ets/base/EtsEntity.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #249      +/-   ##
============================================
- Coverage     60.03%   59.41%   -0.63%     
- Complexity     2244     2247       +3     
============================================
  Files           310      309       -1     
  Lines         18122    18305     +183     
  Branches       3259     3260       +1     
============================================
- Hits          10880    10875       -5     
- Misses         6164     6354     +190     
+ Partials       1078     1076       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Test results on JDK 11

   83 files  ±0     83 suites  ±0   29m 19s ⏱️ - 2m 21s
2 511 tests ±0  2 471 ✅ ±0  40 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 499 ✅ ±0  40 💤 ±0  0 ❌ ±0 

Results for commit 68038a1. ± Comparison against base commit 133474f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Test results on JDK 8

   83 files  ±0     83 suites  ±0   33m 52s ⏱️ + 1m 29s
2 511 tests ±0  2 466 ✅ ±0  45 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 494 ✅ ±0  45 💤 ±0  0 ❌ ±0 

Results for commit 68038a1. ± Comparison against base commit 133474f.

♻️ This comment has been updated with latest results.

@Lipen Lipen marked this pull request as draft August 2, 2024 13:49
@Lipen Lipen marked this pull request as ready for review August 2, 2024 14:05
@Lipen Lipen merged commit 04c4e92 into neo Aug 2, 2024
8 of 10 checks passed
@Lipen Lipen deleted the lipen/ets-values branch August 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants