-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Ets values, operations, visitors #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## neo #249 +/- ##
============================================
- Coverage 60.03% 59.41% -0.63%
- Complexity 2244 2247 +3
============================================
Files 310 309 -1
Lines 18122 18305 +183
Branches 3259 3260 +1
============================================
- Hits 10880 10875 -5
- Misses 6164 6354 +190
+ Partials 1078 1076 -2 ☔ View full report in Codecov by Sentry. |
CaelmBleidd
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some improvements in the design of Ets operations (enums are replaced with classes) and also simplifies
EtsValue
visitors (merge visitors for Immediate, Constant, Ref into one).In addition, the type of
EtsIfStmt.condition
was changed fromEtsConditionExpr
toEtsEntity
, since JS/TS allows "implicit" constructions such asif (x) {...}
. See also: https://gitee.com/openharmony-sig/arkanalyzer/issues/IAHIJ5