Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashCode for EtsClassSignature #252

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Aug 5, 2024

This PR adds hashCode() impl for EtsClassSignature which already overrides equals.

@Lipen Lipen requested a review from zishkaz August 5, 2024 22:35
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 49s ⏱️ -7s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 28d2b4d. ± Comparison against base commit 00164e3.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Test results on JDK 19

   83 files  ±0     83 suites  ±0   25m 53s ⏱️ +9s
2 511 tests ±0  2 469 ✅ ±0  42 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 497 ✅ ±0  42 💤 ±0  0 ❌ ±0 

Results for commit 28d2b4d. ± Comparison against base commit 00164e3.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.54%. Comparing base (00164e3) to head (28d2b4d).

Additional details and impacted files
@@            Coverage Diff            @@
##                neo     #252   +/-   ##
=========================================
  Coverage     59.53%   59.54%           
  Complexity     2238     2238           
=========================================
  Files           309      309           
  Lines         18297    18298    +1     
  Branches       3261     3261           
=========================================
+ Hits          10894    10895    +1     
  Misses         6329     6329           
  Partials       1074     1074           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Test results on JDK 11

   83 files  ±0     83 suites  ±0   29m 27s ⏱️ +5s
2 511 tests ±0  2 471 ✅ ±0  40 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 499 ✅ ±0  40 💤 ±0  0 ❌ ±0 

Results for commit 28d2b4d. ± Comparison against base commit 00164e3.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Test results on JDK 8

   83 files  ±0     83 suites  ±0   32m 37s ⏱️ + 3m 36s
2 511 tests ±0  2 466 ✅ ±0  45 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 494 ✅ ±0  45 💤 ±0  0 ❌ ±0 

Results for commit 28d2b4d. ± Comparison against base commit 00164e3.

@Lipen Lipen merged commit d6e0456 into neo Aug 6, 2024
12 checks passed
@Lipen Lipen deleted the lipen/class-signature-hash-code branch August 6, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants