pkg(htc): add HTC Lockscreen and Weather themes #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
AnonymousWP
changed the title
AnonymousWP
requested changes
Nov 25, 2024
Comment on lines
+29014
to
+29021
| "com.htc.weather": { | ||
| "list": "Oem", | ||
| "description": "HTC Weather", | ||
| "dependencies": [], | ||
| "neededBy": [], | ||
| "labels": [], | ||
| "removal": "Advanced" | ||
| }, |
There was a problem hiding this comment.
Does disabling/uninstalling this package break anything?
There was a problem hiding this comment.
Nothing of the sort was reported.
There was a problem hiding this comment.
Then why is it Advanced and not Recommended?
There was a problem hiding this comment.
why is it
Advancedand notRecommended?
I guess it's because we have minimal info about it 🤔. I agree with Advanced as a default (for that pack), as it seems "extra", but we can't be sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.