Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting continuous extrapolation in servoThread #217

Open
preet-dhir1-ocado opened this issue Oct 14, 2024 · 1 comment
Open

Limiting continuous extrapolation in servoThread #217

preet-dhir1-ocado opened this issue Oct 14, 2024 · 1 comment

Comments

@preet-dhir1-ocado
Copy link

preet-dhir1-ocado commented Oct 14, 2024

Affected Client Library version(s)
1.3.7

What combination of platform is the Client Library running on.
Linux

How did you install the Client Library
Build the library from source

Which robot platform is the library connected to.
URSim in docker

Robot SW / URSim version(s)
5.16.0

How are you using the Client Library

Through the robot teach pendant using External Control URCap

Summary

Currently in ServoThread, there is no limit to how many consecutive extrapolations can occur. In the case of a connection drop, the arm ends up moving a large distances. I wanted to share the fix that we have been using for this issue and was looking to push it upstream.

Draft PR with the fix: #216

@fmauch
Copy link
Collaborator

fmauch commented Oct 14, 2024

In case of a connection drop reading the next command should fail leading to control_mode being set to STOPPED which will in turn end the while loop and shut down the motion thread.

Or in other words: The robot extrapolates as long as the number of missed packages is still in the range of allowed packages to be missed.

What is your setup where you experience these issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants