Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use previous or next results buttons when searching through a single page item #923

Closed
1 of 3 tasks
thms-rmb opened this issue Jun 19, 2023 · 1 comment
Closed
1 of 3 tasks

Comments

@thms-rmb
Copy link

UV version:

I'm submitting a:

  • bug report => please fork one of these codesandbox examples with a repro of your issue and include a link to it below
  • feature request => please use the user stories repo
  • support request => Please do not submit support requests here, use stackoverflow

Current behavior:

When I am viewing a single page item, I can search for a term but I cannot click on the Previous Result or Next Result buttons.

Expected behavior:

I expect to be able to search for a term and then to click on the Previous Result and Next Result to navigate between the search results.

Steps to reproduce:

You can see the effect of searching on a single page item here: https://codesandbox.io/s/single-page-does-not-support-navigating-search-results-yqltjh?file=/index.html:652-865

  1. Search for e.g. rabbit in the "Search within this item" field (you may need to make the preview frame wider to see the search input on codesandbox)
  2. See search results in the page above
  3. Unable to click previous result or next result buttons

It seems that the problem does not appear when there are multiple pages for an item. See here, where I've included two pages: https://codesandbox.io/s/multi-page-does-support-navigating-search-results-978dgh?file=/index.html:334-340

Related code:

// insert any relevant code here

Other information:

@jamesmisson
Copy link
Contributor

This has been fixed and a PR submitted: #1053

@github-project-automation github-project-automation bot moved this from Community backlog to Completed in Universal Viewer Community Board Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

4 participants