-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versions beginning with 4.0.24 not working with Next.js #954
Comments
@firatciftci, unfortunately I don't have much experience with Next.js, so I don't have an immediate theory about what would have caused this... but I wonder if it's worth noting here exactly which version of Next.js you are using, in case that is also a factor in some way. |
@demiankatz Fair point; I am using Next.js version 14.0.4. |
@firatciftci, out of curiosity, I just looked at the diffs to see exactly what changed in release 4.0.24, and the answer is not very much: The only change is a bump in the version of the iiif-av-component, which doesn't seem like it ought to be the sort of thing to break the entire application. It might be interesting to see what would happen if you checked out v4.0.25 and downgraded the iiif-av-component. Would it start working again? If so, we'd at least know who the culprit is; if not, then there must be some other variable I'm overlooking.... |
@demiankatz v4.0.23 is actually not published on npm, so I could not test that one out. I think focusing on the difference between v4.0.22 and v4.0.23/24 is more useful here (v4.0.22 works without any issues): |
I don't see anything that seems like an obvious breaking change here. Perhaps the most likely suspect is the work from #906 since that changes the way some files are organized and loaded (and accounts for a larger number of changed files than most of the other commits combined), but I don't see an obvious red flag in the way it is done. |
UV version:
I'm submitting a:
Current behavior:
I am running a Next.js web application and I am using UniversalViewer through the Next.js example posted in the documentation, exactly as-is. The only difference with the example code is the version of the package; up until version 4.0.24 (not inclusive), the code runs perfectly fine, but starting with version 4.0.24 (which includes the current up-to-date version, 4.0.25), whenever I try to use the component in my code, I get the following error:
This appears as if imports for dependencies or local files in the most recent versions became incompatible with how Next.js operates, but this is just an educated guess on my part.
Expected behavior:
The viewer displays normally, without any issues.
Steps to reproduce:
Related code:
Other information:
N/A
The text was updated successfully, but these errors were encountered: