Expose ImpressionData property from api.Feature type #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgrigoruk
force-pushed
the
vgrigoruk/add-impression-data-to-feature
branch
from
edb8d91
to
9560cee
Compare
|
@vgrigoruk Thanks for this PR. This is actually a missing capability in the Go SDK. The impressionData flag is used internally in other SDKs to emit impression event with the context that was provided to the IsEnabled or GetVariant call. See Unleash/unleash-client-node#336 for details. I'm happy to merge this property change. But it won't do anything until we add the functionality to emit the events based on this property. |
|
Added #182 as an issue on the repository. |
FredrikOseberg
approved these changes
Oct 25, 2024
|
Thanks @FredrikOseberg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Currently, there is no way to access "impressionData" property on the feature object, as it is not exposed via
Featuretype, so there is no way to implement "impressions" logic based on boolean flag that is set on per-feature basis.