Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggles parse error #83

Closed
makunterry opened this issue Mar 18, 2024 · 3 comments · Fixed by #84
Closed

Toggles parse error #83

makunterry opened this issue Mar 18, 2024 · 3 comments · Fixed by #84
Labels
bug Something isn't working

Comments

@makunterry
Copy link

Describe the bug

Hi experts, I met with an error when the proxy sdk try to decode the api/frontend response from server, the response string is:

{"toggles":[{"name":"Android-FeatureFlag-Demo","enabled":true,"impressionData":false},{"name":"Android-FeatureFlag-Test","enabled":true,"impressionData":false}]}

And the expection throwed when decoding the data:
image

I think it should be related with the toggle definition that missing some field like 'impressionData'.
image

Will this be fixed soon? or is there some mismatch with the server version?
BTW, I am using the sdk version 1.2.0.

Steps to reproduce the bug

No response

Expected behavior

No response

Logs, error output, etc.

No response

Screenshots

No response

Additional context

No response

Unleash version

1.2.0

Subscription type

Open source

Hosting type

Self-hosted

SDK information (language and version)

ios swift sdk

@makunterry makunterry added the bug Something isn't working label Mar 18, 2024
@kwasniew
Copy link
Contributor

@makunterry what version of Unleash backend are you running? It looks like the variant information is missing in your server response. The swift client is not very forgiving about it. We'll create a patch for the client to be more forgiving soon.

@kwasniew
Copy link
Contributor

Can you check if this code #84 works for you?

@makunterry
Copy link
Author

@kwasniew
Thanks for your responding, the changed Toggle definition works well on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants