Allow attaching completion handler for updating context. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DenTelezhkin Thanks for contributing! v1.2.0 should be out that includes this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This PR adds optional completion handler to
updateContextmethod. This is needed to receive a callback once update is complete.My use-case:
I need to receive updated configuration after user logs in (several user profile fields are set in context). Those fields can determine A/B test variants and feature flags user can receive. To achieve this, I call updateContext(completion:) before letting user in the app after logging in.
Discussion points
This addition is non-breaking, as parameter has default value of nil.
I also removed
stopmethod call in this function, asstopmethod is already called instartfunction. However, this change is optional, I can put it back if maintainers think it's good for consistency.