From 088eaedbc31530e82e00679dcba7c2607226b624 Mon Sep 17 00:00:00 2001 From: Thomas Heartman Date: Wed, 13 Nov 2024 14:52:43 +0100 Subject: [PATCH] feat: add tooltips to lifecycle boxes (#8739) This pr adds tooltips to lifecycle boxes when they're hovered or focused. There's also some small copy tweaks. We decided to go with tooltips instead of buttons for this iteration because it'd be an easier thing to implement, especially in regards to keyboard navigation and avoiding overlapping other elements. I've also not changed the background color of the tooltips just yet. There's two reasons for this: 1. The practical reason is that our `HtmlTooltipComponent` doesn't allow you to do that and I didn't wanna start messing about with that. 2. If all our other tooltips follow this color scheme, why not do the same here? Especially because they're not buttons anymore, so using the same color as other tooltips seems sensible. ![image](https://github.com/user-attachments/assets/2e0ebf26-6809-4952-87db-9b7d2838eed7) --- .../ProjectStatus/LifecycleMessages.ts | 8 +- .../ProjectStatus/ProjectLifecycleSummary.tsx | 80 +++++++++---------- 2 files changed, 43 insertions(+), 45 deletions(-) diff --git a/frontend/src/component/project/Project/ProjectStatus/LifecycleMessages.ts b/frontend/src/component/project/Project/ProjectStatus/LifecycleMessages.ts index 3641cca2ffdb..8669886c0651 100644 --- a/frontend/src/component/project/Project/ProjectStatus/LifecycleMessages.ts +++ b/frontend/src/component/project/Project/ProjectStatus/LifecycleMessages.ts @@ -5,12 +5,12 @@ export const lifecycleMessages: Record< string > = { initial: - 'Feature flags in the initial phase indicate you have created flags that is not detected in any environments which mean either integration issues or unused flags', + 'Feature flags in the initial phase are flags that have not yet received metrics from any environments. This might mean that the flags have not been used yet, or it could indicate integration issues.', preLive: - 'In the pre-live phase the feature is being developed and tested in controlled environments. Once the feature is ready the flag can be enabled in production.', - live: 'The feature is being rolled out in production according to the decided strategy targeting user segments and/or using percentage rollout. ', + 'In the pre-live phase, the feature is being developed and tested in controlled environments. Once the feature is ready, the flag can be enabled in production.', + live: 'The feature is being rolled out in production according to its assigned strategies (targeting user segments and/or using percentage rollout).', completed: - 'Flags that are in cleanup are potentially stale flags. View the flags to evaluate whether you should archive them in Unleash and clean up your codebase to reduce technical debt', + 'Flags that are in the completed phase still receive metrics in production. Consider archiving them to clean up your codebase to reduce technical debt.', archived: 'Flags that have been archived and are no longer in use, but kept for future reference.', }; diff --git a/frontend/src/component/project/Project/ProjectStatus/ProjectLifecycleSummary.tsx b/frontend/src/component/project/Project/ProjectStatus/ProjectLifecycleSummary.tsx index a872ace6b448..b59a48111d32 100644 --- a/frontend/src/component/project/Project/ProjectStatus/ProjectLifecycleSummary.tsx +++ b/frontend/src/component/project/Project/ProjectStatus/ProjectLifecycleSummary.tsx @@ -1,13 +1,15 @@ -import { CardActionArea, styled } from '@mui/material'; +import { styled } from '@mui/material'; import { FeatureLifecycleStageIcon } from 'component/feature/FeatureView/FeatureOverview/FeatureLifecycle/FeatureLifecycleStageIcon'; import { useProjectStatus } from 'hooks/api/getters/useProjectStatus/useProjectStatus'; import useLoading from 'hooks/useLoading'; import { useRequiredPathParam } from 'hooks/useRequiredPathParam'; -import { useState, type FC } from 'react'; +import type { FC } from 'react'; import { PrettifyLargeNumber } from 'component/common/PrettifyLargeNumber/PrettifyLargeNumber'; import type { ProjectStatusSchemaLifecycleSummary } from 'openapi'; -import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig'; import { HelpIcon } from 'component/common/HelpIcon/HelpIcon'; +import { HtmlTooltip } from 'component/common/HtmlTooltip/HtmlTooltip'; +import { lifecycleMessages } from './LifecycleMessages'; +import InfoIcon from '@mui/icons-material/Info'; const LifecycleRow = styled('div')(({ theme }) => ({ display: 'flex', @@ -33,32 +35,46 @@ const LifecycleBoxContent = styled('div')(({ theme }) => ({ transition: 'border-color 200ms', borderRadius: theme.shape.borderRadiusExtraLarge, border: `2px solid ${theme.palette.divider}`, -})); - -const StyledCardActionArea = styled(CardActionArea)(({ theme }) => ({ - borderRadius: theme.shape.borderRadiusExtraLarge, - '&[aria-pressed="true"] > *': { + '&:focus-visible': { + outline: 'none', borderColor: theme.palette.primary.main, }, })); +const LifecycleBoxTooltip: FC<{ text: string }> = ({ text }) => { + const Container = styled('span')(({ theme }) => ({ + display: 'flex', + alignItems: 'flex-start', + gap: theme.spacing(1), + fontSize: theme.typography.body1.fontSize, + padding: theme.spacing(1), + })); + return ( + + +

{text}

+ + ); +}; + const LifecycleBox = ({ children, - isActive, - onClick, + tooltipText, }: { children: React.ReactNode; - isActive?: boolean; - onClick?: () => void; + tooltipText: string; }) => { return (
  • - } > - {children} - + + {children} + +
    • ); }; @@ -171,11 +187,7 @@ const LifecycleTooltip: FC = () => { export const ProjectLifecycleSummary = () => { const projectId = useRequiredPathParam('projectId'); const { data, loading } = useProjectStatus(projectId); - const { isEnterprise } = useUiConfig(); - const [activeLifecycleStage, setActiveLifecycleStage] = useState< - keyof ProjectStatusSchemaLifecycleSummary | null - >(null); const loadingRef = useLoading( loading, '[data-loading-project-lifecycle-summary=true]', @@ -193,11 +205,9 @@ export const ProjectLifecycleSummary = () => {

    Flag lifecycle

    + - setActiveLifecycleStage('initial')} - isActive={activeLifecycleStage === 'initial'} - > +

    { averageDays={data?.lifecycleSummary.initial.averageDays} /> - setActiveLifecycleStage('preLive')} - isActive={activeLifecycleStage === 'preLive'} - > +

    { averageDays={data?.lifecycleSummary.preLive.averageDays} /> - setActiveLifecycleStage('live')} - isActive={activeLifecycleStage === 'live'} - > +

    { averageDays={data?.lifecycleSummary.live.averageDays} /> - setActiveLifecycleStage('completed')} - isActive={activeLifecycleStage === 'completed'} - > +

    { } /> - setActiveLifecycleStage('archived')} - isActive={activeLifecycleStage === 'archived'} - > +