chore: remove featureSwitchRefactor flag #5329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Tymek
commented
Nov 14, 2023
| @@ -96,7 +96,11 @@ export const useFeatureToggleSwitch: UseFeatureToggleSwitchType = ( | |||
| }; | |||
|
|
|||
| const ensureActiveStrategies: Middleware = (next) => { | |||
| if (!config.hasStrategies || config.hasEnabledStrategies) { | |||
| if ( | |||
| newState === false || | |||
There was a problem hiding this comment.
Other conditions should never be met with newState===false, but adding this makes it more consistent with our actual business logic
Tymek
commented
Nov 14, 2023
| refetchFeature(); | ||
| if (callback) callback(); | ||
| }; | ||
| const handleToggle = (newState: boolean, onRollback: () => void) => |
There was a problem hiding this comment.
Using new FeatureSwitch here allows us to remove legacy implementation not only from the table.
FredrikOseberg
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup. This change has been rolled out to significant number of customers already, and we have another parallel version behind a flag.