Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new columns visibility menu #5604

Merged
merged 2 commits into from
Dec 12, 2023
Merged

feat: new columns visibility menu #5604

merged 2 commits into from
Dec 12, 2023

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Dec 11, 2023

About the changes

Simplified columns visibility menu.

<ColumnsMenu /> is using it's own list of elements instead of inferring it from table columns definition. This component doesn't need it's internal structure to depend on react-table and it's interface.

@Tymek Tymek requested a review from kwasniew December 11, 2023 16:35
Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:22am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:22am

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some explanation what was simplified so that we have some "lightweight ADR like description" inside this PR. In the past I was browsing some old commits where I tried to understand the context and longer descriptions were usually helpful.

@Tymek Tymek merged commit 8a5a73a into main Dec 12, 2023
13 checks passed
@Tymek Tymek deleted the feat/new-columns-menu-toggle branch December 12, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants