Update feature-flag-best-practices.md #7801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@riboflavin is attempting to deploy a commit to the unleash-team Team on Vercel. A member of the Team first needs to authorize it. |
ferrantim
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Hi @riboflavin this looks generally good. I would like to add the images back and to fix the suggestions that I have made. Once you do that, you can resubmit the PR for approval.
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
|
|
||
| A large-scale feature flag system that enables runtime control should have at minimum the following components: | ||
| * [11\. Enable traceability. Make it easy to understand flag evaluation.](https://docs.getunleash.io/topics/feature-flags/feature-flag-best-practices\#11-enable-traceability-make-it-easy-to-understand-flag-evaluation) |
There was a problem hiding this comment.
This anchor text is not being rendered. All the other ones are though
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
|
|
||
| **5. Continuously Updated**: Implement update mechanisms in your application so that changes to feature flag configurations are reflected without requiring application restarts or redeployments. The SDK should handle subscriptions or polling to the feature flag service for updates. | ||
| 5\. Continuously Updated: Implement update mechanisms in your application so that changes to feature flag configurations can be made without requiring application restarts or redeployments. The SDK should handle subscriptions or polling to the feature flag service for updates. |
There was a problem hiding this comment.
A large-scale feature flag system that enables runtime control should have at minimum the following components:
I think number 5 is not really a component per se. I can also look into this in a separate PR.
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
website/docs/topics/feature-flags/feature-flag-best-practices.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Ferranti <[email protected]>
Co-authored-by: Michael Ferranti <[email protected]>
Co-authored-by: Michael Ferranti <[email protected]>
Co-authored-by: Michael Ferranti <[email protected]>
Co-authored-by: Michael Ferranti <[email protected]>
Co-authored-by: Michael Ferranti <[email protected]>
Co-authored-by: Michael Ferranti <[email protected]>
Co-authored-by: Melinda Fekete <[email protected]>
Co-authored-by: Melinda Fekete <[email protected]>
Co-authored-by: Melinda Fekete <[email protected]>
Co-authored-by: Michael Ferranti <[email protected]>
Co-authored-by: Melinda Fekete <[email protected]>
Co-authored-by: Melinda Fekete <[email protected]>
Co-authored-by: Melinda Fekete <[email protected]>
Co-authored-by: Melinda Fekete <[email protected]>
Co-authored-by: Melinda Fekete <[email protected]>
Co-authored-by: Melinda Fekete <[email protected]>
Co-authored-by: Melinda Fekete <[email protected]>
Co-authored-by: Melinda Fekete <[email protected]>
Co-authored-by: Michael Ferranti <[email protected]>
Co-authored-by: Michael Ferranti <[email protected]>
Co-authored-by: Michael Ferranti <[email protected]>
|
Superseded by #7907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the Best Practices pages.