chore: implement event grouping in the event timeline #8254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
nunogois
force-pushed
the
chore-event-timeline-event-grouping
branch
from
18fffab to
39d841c
Compare
nunogois
commented
Sep 26, 2024
| components, | ||
| ...props | ||
| }: ComponentProps<typeof ReactMarkdown>) => ( | ||
| <ReactMarkdown components={{ a: LinkRenderer, ...components }} {...props} /> |
There was a problem hiding this comment.
For anyone coming across this: This was part of an experiment where we customized em components within our markdown renderer, in this case specifically for the timeline event tooltip.
Even though we ended up choosing a different approach, we still see this as an improvement (scouting) that could be helpful for future cases where we need to override specific components in the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2663/implement-event-grouping-when-multiple-events-happen-in-a-short-period
This PR introduces a grouping logic for timeline events, enhancing the way events are displayed when they occur close to each other.
We also updated and refactored components to support handling groups of events rather than individual events.
Also includes some minor code cleanups and optimizations as part of general refactoring efforts (scouting).