chore: upgrade to biome 1.9.4 #8616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dependency ReviewThe following issues were found:
License Issuesfrontend/yarn.lock
yarn.lock
Allowed Licenses: Apache-2.0, MIT, BSD-2-Clause, BSD-3-Clause, ISC, 0BSD, CC0-1.0, Unlicense, BlueOak-1.0.0, CC-BY-4.0 OpenSSF ScorecardScorecard details
Scanned Files
|
kwasniew
reviewed
Oct 31, 2024
| "linter": { | ||
| "enabled": true, | ||
| "rules": { | ||
| "recommended": true, | ||
| "a11y": { | ||
| "useSemanticElements": "off" |
There was a problem hiding this comment.
can we add explanation in the PR why those changes were needed? have some defaults changed?
There was a problem hiding this comment.
Yes, good suggestion. Added as main comment to PR, will include in merge commit message
kwasniew
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two lints being turned off are new for 1.9.x and caused a massive diff inside frontend if activated, to reduce impact, turned them off for the merge. We might want to look at turning them back on once we're ready to have a semantic / a11y refactor of our frontend