Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseClasses has no filter #66

Open
Mikk155 opened this issue Mar 25, 2023 · 14 comments
Open

BaseClasses has no filter #66

Mikk155 opened this issue Mar 25, 2023 · 14 comments
Assignees
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@Mikk155
Copy link

Mikk155 commented Mar 25, 2023

BaseClasses in the FGD has not filter when displaying them in BSPGuy.
i.e you have a entity that is PointClass and SolidClass as well.

Sample:

@BaseClass = bBBox
[
    minhullsize(string) : "Minimun BBox Size"
    maxhullsize(string) : "Maximun BBox Size"
]
@BaseClass base( bTargetname, bRenderamt, bRendercolor ) = bGeiger
[
    health(float) : "Minimun delay" : 0.1
    max_health(float) : "Maximun delay" : 1.0
    sound#1(sound) : "Sound FX" : "player/geiger1.wav"
    sound#2(sound) : "Sound FX" : "player/geiger2.wav"
    sound#3(sound) : "Sound FX" : "player/geiger3.wav"
    sound#4(sound) : "Sound FX" : "player/geiger4.wav"
    sound#5(sound) : "Sound FX" : "player/geiger5.wav"
    sound#6(sound) : "Sound FX" : "player/geiger6.wav"
]
@PointClass base(bGeiger, bBBox) = env_geiger : "geiger"[]
@SolidClass base(bGeiger) = env_geiger : "geiger"[]

min/maxhullsize will be displayed in both Class of the entity, in this example, hullsizes should only be displayed on the PointClass of the entity, would be easy to verify if the key model starts with asterisk * if so, use SolidClass, else use PointClass

@Mikk155 Mikk155 closed this as completed Mar 25, 2023
@Mikk155 Mikk155 reopened this Mar 25, 2023
@Qwertyus3D
Copy link

An entity should not be both Point & Solid.

@Mikk155
Copy link
Author

Mikk155 commented Mar 31, 2023

An entity should not be both Point & Solid.

A entity can work as both, the model only defines if its solid and do things depending on that, an yet that's a custom entity made by me in Sven Coop. If point, it uses radius, if solid, it uses its bbox.

@UnrealKaraulov UnrealKaraulov self-assigned this Dec 5, 2023
@UnrealKaraulov UnrealKaraulov added the enhancement New feature or request label Dec 5, 2023
@UnrealKaraulov
Copy link
Owner

UnrealKaraulov commented Dec 9, 2023

@Mikk155 newbspguy can't support duplicate names at this time

@Mikk155 what editor can works with this fgd ?

@Mikk155
Copy link
Author

Mikk155 commented Dec 9, 2023

Let's say i have a entity that is both a point entity and a brush entity, The game code just checks if it's a BSPModel and make the entity behave as.

The entity that is the last readed in the FGD will be the definitive fields, ignoring the others

This is a brush entity, doesn't have hullsizes fields

@SolidClass = antirush : "Anti Rush"
[
]

The point entity does have them

@PointClass= antirush : "Anti Rush"
[
    minhullsize(string) : "Custom Min Hull Size (X Y Z)" : "0 0 0"
    maxhullsize(string) : "Custom Max Hull Size (X Y Z)" : "0 0 0"
]

If i swap the point entity to be above the solid entity, it won't give hullsize to any of them, because the last entity in the fgd is overwritting the previous one, what i would want is BSPGuy to proper give the entity's keyvalue fields specific if point or brush, just as JACK/SDK does, you can't find trigger_changelevel in the point entities section, and even if you force it, it won't show any fields.

I didn't saw the code and to be honest i am newbie programing but that shouldn't take more than checking if the value of the key model starts with *

@UnrealKaraulov
Copy link
Owner

@Mikk155 please tell me name of Editor that can support your FGD file.

@UnrealKaraulov
Copy link
Owner

UnrealKaraulov commented Dec 10, 2023

This feature can not be supported if no map editor that support this feature.

@UnrealKaraulov UnrealKaraulov added invalid This doesn't seem right wontfix This will not be worked on labels Dec 10, 2023
@UnrealKaraulov UnrealKaraulov closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@Mikk155
Copy link
Author

Mikk155 commented Dec 10, 2023

J.A.C.K and i guess Hammer does as well
image

@SolidClass base(Targetname, Target) = test : "Test"
[
]

@PointClass base(Targetname, Target) = test : "Test" 
[
	radius(integer) : "Radius"
	maxhullsize(string) : "Max hullsize" : "0 0 0"
	minhullsize(string) : "Min hullsize" : "0 0 0"
]

In this case, BSPGuy will only read the last registered entity in the FGD and use that information for both if BRUSH or POINT

@UnrealKaraulov
Copy link
Owner

@Mikk155 now, in latest version, your fgd works?

@Mikk155
Copy link
Author

Mikk155 commented Dec 18, 2023

Doesn't seems to, i am using the example i previously sent.
it is using the information of the first one loaded(not hullsizes nor radius shown), and if i open the propierty of the brush one, then in the point entity will appear the "model" keyvalue

@UnrealKaraulov
Copy link
Owner

@Mikk155 but you can't change point to solid class even in J.A.C.K

@Mikk155 try again https://github.com/UnrealKaraulov/newbspguy/releases/tag/NightBuild_2023.12.18_05-34

Now fixed merge two or more fgd files, and some fixes in "model" check.

@UnrealKaraulov UnrealKaraulov removed the wontfix This will not be worked on label Dec 18, 2023
@UnrealKaraulov
Copy link
Owner

@Mikk155 if this issue not fixed, please tell me below.

@Mikk155
Copy link
Author

Mikk155 commented Jan 29, 2024

Sorry, i completely forgot, no, the problem still remains

image
image

you can test by yourself with the FGD i previously sent in here

@UnrealKaraulov
Copy link
Owner

@Mikk155 and you can't change class to solid?

@Mikk155
Copy link
Author

Mikk155 commented Jan 31, 2024

didn't tried it, in any ways this issue was more like an improve, since BSPGuy never filtered repeated classes as other level design tools does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants