Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove abstract decorator from initialize in BaseEmbeddingEncoder #3730

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove abstract decorator from initialize in BaseEmbeddingEncoder #3730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion unstructured/embed/interfaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class EmbeddingConfig(BaseModel):
class BaseEmbeddingEncoder(ABC):
config: EmbeddingConfig

@abstractmethod
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the implementation of BaseEmbeddingEncoder in unstructured_ingest: https://github.com/Unstructured-IO/unstructured-ingest/blob/main/unstructured_ingest/embed/interfaces.py#L16

def initialize(self):
"""Initializes the embedding encoder class. Should also validate the instance
is properly configured: e.g., embed a single a element"""
Expand Down