Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CXX_EXTRA_FLAGS does not support passing multiple flags #4

Open
andreipoe opened this issue Sep 2, 2020 · 0 comments
Open

CXX_EXTRA_FLAGS does not support passing multiple flags #4

andreipoe opened this issue Sep 2, 2020 · 0 comments

Comments

@andreipoe
Copy link

Building fails when CXX_EXTRA_FLAGS contains more than one flag:

cmake -Btest -H. -DCMAKE_BUILD_TYPE=Release -DSYCL_RUNTIME=HIPSYCL -DCXX_EXTRA_FLAGS='-march=armv8.3-a+sve -ffp-contract=fast'
cmake --build test --target clover_leaf --config Release -j 1 -v

The flags aren't properly passed to the compiler (full paths removed for clarity):

...
[  3%] Building SYCL object CMakeFiles/clover_leaf.dir/src/accelerate.cpp.o
syclcc-clang  -I... -W...  -O3 "-march=armv8.3-a+sve -ffp-contract=fast" -pthread -o ...
cc1plus: error: invalid feature modifier in ‘-march=armv8.3-a+sve -ffp-contract=fast’

Setting a single flag, e.g. -DCXX_EXTRA_FLAGS=-march=armv8.3-a+sve, works correctly.
@andreipoe andreipoe changed the title CXX_EXTRA_FLAGS only supports passing a single flag CXX_EXTRA_FLAGS does not support passing multiple flags Sep 2, 2020
tom91136 added a commit that referenced this issue Jan 10, 2021
@tom91136
Add support for substring based device selection
64e3693 
Add support for pre-SYCL1.2.1R3 standard
Add support for custom dpcpp paths
Add move semantic handling workaround in field_summary for old ComputeCpp versions
Fixed COMPUTECPP_USER_FLAGS from being overwritten
Fixed CXX_EXTRA_FLAGS/CXX_EXTRA_LINKER_FLAGS space handling, closes #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andreipoe