Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for redis+sentinel url #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HugoPoi
Copy link
Contributor

@HugoPoi HugoPoi commented Feb 2, 2022

Description

This is a

  • Feature

Checklists

Commit style

  • Changes are on a branch with a descriptive name eg. fix/missing-queue, docs/setup-guide

  • Commits start with one of feat: fix: docs: chore: or similar

  • No excessive commits, eg: there should be no fix: commits for bugs that existed only on the PR branch (see guide-to-interactive-rebasing)

Protected files

The following files should not change unless they are directly a part of your change.

  • yarn.lock (unless package.json is also modified, then only the new/updated package should be changed here)

  • package.json (renovate bot should handle all routine updates)

  • package-lock.json (Should not exist as this project uses yarn)

  • tsconfig.json (only make it stricter, making it more lenient requires more discussion)

  • tslint.json (only make it stricter, making it more lenient requires more discussion)

@HugoPoi HugoPoi force-pushed the feat/support-sentinel-url branch 2 times, most recently from d48bda6 to 90da2cb Compare February 15, 2022 09:30
@HugoPoi HugoPoi force-pushed the feat/support-sentinel-url branch from 90da2cb to 0c44c51 Compare February 15, 2022 11:57
@HugoPoi
Copy link
Contributor Author

HugoPoi commented Feb 15, 2022

redis-url-plus has been merged ! And I have tested the docker build and the image

@atmosx
Copy link

atmosx commented Oct 22, 2024

redis-url-plus has been merged ! And I have tested the docker build and the image

merged where? I don't see this merged. Nvm, you were talking about another project. Anyhow, I build an image locally and tested the PR, doesn't seem to work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants