Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weighted points #77

Open
1 of 2 tasks
dabreegster opened this issue Sep 12, 2024 · 8 comments · May be fixed by #82
Open
1 of 2 tasks

Weighted points #77

dabreegster opened this issue Sep 12, 2024 · 8 comments · May be fixed by #82
Assignees

Comments

@dabreegster
Copy link
Collaborator

dabreegster commented Sep 12, 2024

Let the user specify a weight per origin or destination point. When randomly sampling points inside a zone, use this weight.

  • Make an example demonstrating this feature clearly
  • Document it (and more generally, overhaul the docs on config and input formats)
@Robinlovelace
Copy link
Collaborator

This is great to see! Thanks for opening it.

@Robinlovelace
Copy link
Collaborator

Can have a look at docs, good timing for use cases.

@Robinlovelace
Copy link
Collaborator

Robinlovelace commented Sep 12, 2024

One thing I can do: add minimal input for tests. Will track that here, when I get a chance.

@Robinlovelace Robinlovelace self-assigned this Sep 12, 2024
@dabreegster
Copy link
Collaborator Author

Thanks! Ultimately I'd like the docs to have some discussion of how to make good input data. For using OSM buildings, for instance, the user needs to be aware of the uneven coverage. For weighting, I'm not sure in practice how to pick weights, other than vague ideas like "more square footage for a shop means more important" and "flats with more height are more important"

@Robinlovelace
Copy link
Collaborator

For weighting, I'm not sure in practice how to pick weights, other than vague ideas like "more square footage for a shop means more important" and "flats with more height are more important"

Well that can be a problem for the user to figure out.. Will aim to get a minimal example input dataset today. One observation: lots of the examples in the examples folder are big, could be good to have small ones like 10 zones to 1 destination I'm thinking.

@Robinlovelace
Copy link
Collaborator

Taking a look at this now...

@Robinlovelace Robinlovelace linked a pull request Sep 24, 2024 that will close this issue
Robinlovelace added a commit that referenced this issue Sep 24, 2024
@Robinlovelace
Copy link
Collaborator

Just discussing this with @wangzhao0217, and looking to use this functionality in NPT work.

@dabreegster
Copy link
Collaborator Author

I'll try and catch up on PRs / docs for this soon then. Keep me posted how you actually decide the weights!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants