Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to correct code from tutorial, suggestions for step 1 #34

Open
micdahl opened this issue Jun 22, 2017 · 0 comments
Open

Unable to correct code from tutorial, suggestions for step 1 #34

micdahl opened this issue Jun 22, 2017 · 0 comments

Comments

@micdahl
Copy link

micdahl commented Jun 22, 2017

When clicking on 'Improve this code' on the tutorial setup, I see markdown code which is not identical to the content of the page. Because of this I was not able to create a pull request for the corrections I had to make to get Step 1 running.

So I write down the changes in code I had to make to come through step 1 at this place:

in 1.10:
remove line 222 (typography.scss does not exist in the nodes_module)

in 1.12:
add .woff2-mapping for all roboto-... fonts

in 1.13:
add import { BrowserModule } from '@angular/platform-browser';
and change imports to:

  imports: [
    IonicModule.forRoot(MyApp),
    BrowserModule
  ],
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant