Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks restricts to only Node.js usage #1697

Closed
PabloSzx opened this issue May 24, 2021 · 7 comments · Fixed by #2461 · May be fixed by #2255
Closed

async_hooks restricts to only Node.js usage #1697

PabloSzx opened this issue May 24, 2021 · 7 comments · Fixed by #2461 · May be fixed by #2255
Assignees
@enisdenjo
Labels
kind/enhancement New feature or request

Comments

@PabloSzx
Copy link
Contributor

Right now GraphQL Modules uses a Node.js specific module async_hooks in /packages/graphql-modules/src/application/execution-context.ts, and that restricts the usage of GraphQL Modules to only Node.js, making it harder/impossible to be used in other environments like Deno or Cloudflare workers.

Workaround: In this repo I had to add a no-op for async_hooks to be able to include it in the Cloudflare workers environment

Describe the solution you'd like

Re-factor the current implementation to not require async_hooks

Describe alternatives you've considered

Ship an extra module that doesn't include the async_hooks usage.
@dotansimha dotansimha added the kind/enhancement New feature or request label May 25, 2021
@taras
Copy link

taras commented Aug 26, 2022

We recently hit this problem trying to use GraphQL Modules with Deno. We'd love to help with this if possible.

@dotansimha
Copy link
Collaborator

@kamilkisiela do you think this is something we can find a solution for?

@Jinsung-L
Copy link

I'm having the same problem trying to use it in Cloudflare Workers.

@kamilkisiela kamilkisiela mentioned this issue Sep 28, 2022
Open
@kamilkisiela
Copy link
Collaborator

#2255 but I haven't test it anywhere for leaks

@Jinsung-L
Copy link

#2255 but I haven't test it anywhere for leaks

I've just tested it and it works just fine.

https://github.com/Jinsung-L/graphql-modules-on-cloudflare-workers

https://graphql-modules-on-cloudflare-workers.jinsung.workers.dev

@Dan6erbond
Copy link

I'd like to bump this issue as it's the one thing keeping me from migrating to Deno, which would greatly improve the workflow of working with GraphQL and avoiding a whole list of transpilers and bundlers before I have a workable server. Since there hasn't been many updates with Deno's implementation of the async_hooks denoland/deno#7010 can #2255 be considered or a similar implementation?

@enisdenjo enisdenjo mentioned this issue Nov 2, 2023
Merged
1 task
@enisdenjo
Copy link
Collaborator

Big update, this issue is fixed in [email protected] with #2461. Please try it out! Would be happy to hear that we support Deno now too!

@enisdenjo enisdenjo self-assigned this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enisdenjo enisdenjo

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
7 participants
@taras @dotansimha @kamilkisiela @PabloSzx @enisdenjo @Jinsung-L @Dan6erbond