Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Include/Exclude globs to options, because it is so slow #42

Open
AuthorProxy opened this issue Jan 12, 2020 · 4 comments
Open

Add Include/Exclude globs to options, because it is so slow #42

AuthorProxy opened this issue Jan 12, 2020 · 4 comments

Comments

@AuthorProxy
Copy link

No description provided.

@cdeutsch
Copy link

Wow, I just went from 3 minutes to 2 minutes by removing CaseSensitivePathsPlugin 😳

It is a bit slow.

@Urthen
Copy link
Owner

Urthen commented Feb 21, 2020

If you're having slowness problems, can you run with the {debug: true} option and let me know how many filesystem operations it is performing? That'll help me figure out what kind of scale project you're working on.

As for adding include/exclude globs, I probably won't add that as it would largely defeat the purpose of the plugin (which is to detect case sensitivity errors wherever they occur). However, if you are working on a project with TONS of node-modules dependencies, I think it might be safe to add an option to skip those, as it is much less likely to run into accidents there.

@Urthen Urthen added enhancement waiting Waiting for response from reporter labels Feb 21, 2020
@cdeutsch
Copy link

@Urthen Total filesystem reads: 13,189

@Urthen Urthen removed the waiting Waiting for response from reporter label Feb 26, 2020
@calling
Copy link

calling commented Mar 9, 2020

We're experiencing a similar issue. Total filesystem reads: 15057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants