Fix use of NormalModuleFactory.afterResolve for webpack 5 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why haven't this been merged yet? |
|
Hi @Urthen, is there any perspective on this getting merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming @tim-soft (OP for #56) was having the same issue as @lucasecdb, this change should be enough to add Webpack 5 support (& close #56).
As per the error message shown in @lucasecdb's screenshot, the
NormalModuleFactory.afterResolvehas been changed to a bailing hook, instead of a waterfall hook. So I've updatedcheckFileas a part of this change to reflect that 👍