This repository was archived by the owner on Oct 20, 2022. It is now read-only.
[WIP] feat: Call should end explicitly instead of endCall date #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-trajanovski
requested review from
simonfernandes
and removed request for
a team
Contributor
Author
|
@bolmsten you can double check this now and confirm if the changes are correct. |
Contributor
|
This looks good for ESS, can STFC verify that this would work for them as well? |
…om/UserOfficeProject/user-office-backend into SWAP-2465-end-call-after-cycle-end
simonfernandes
approved these changes
Jun 27, 2022
| /** | ||
| * NOTE: We are comparing dates instead of using the call_ended flag, | ||
| * because the flag is set once per hour and we could have a gap. | ||
| * TODO: Maybe there is a need to use the timezone setting here but not quite sure about it. Discussion is needed here! |
Contributor
There was a problem hiding this comment.
I would have thought this would be fine as new Date().toISOString() and start_call and end_call is all in UTC
Contributor
Author
There was a problem hiding this comment.
@simonfernandes thank you I can remove the comment then. 🙂
jekabs-karklins
approved these changes
Jun 28, 2022
| * TODO: Maybe there is a need to use the timezone setting here but not quite sure about it. Discussion is needed here! | ||
| */ | ||
| const currentDate = new Date().toISOString(); | ||
| if (filter?.isEnded === true) { |
Contributor
There was a problem hiding this comment.
Is the filter value isEnded used? If no service is using it we could consider removing it.
martin-trajanovski
changed the title
martin-trajanovski
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Call should become inactive when the cycle ends not on call end date. Added
is_activeflag on the call to be able to explicitly deactivate/activate calls.Motivation and Context
Previously we were making a call inactive on the call ended date.
How Has This Been Tested
Fixes
https://jira.esss.lu.se/browse/SWAP-2465
Depends on
Frontend PR: UserOfficeProject/user-office-frontend#956
Tests included/Docs Updated?