Skip to content
This repository was archived by the owner on Oct 20, 2022. It is now read-only.

Conversation

@voduguwa
Copy link
Contributor

@voduguwa voduguwa commented Sep 8, 2022

…add tests

Description

Make the publication title field multiline to accommodate for longer titles.
Titles that contain more than 30 characters are truncated, so that it fits within the dialogue box.

Motivation and Context

  • The field accepts 500 characters, so increasing the character limit was not necessary. Longer titles can fit into the text field by being typed on multiple lines.
  • Additionally, Titles that are very long do not fit inside of the dialogue box properly.
  • Some tests needed to be fixed as changes made to ensure titles could be typed on multiple lines broke some tests.

How Has This Been Tested

  • Ensured that the user can type on multiple lines through manual testing.
  • Added check to test to ensure that long titles are truncated after entry.

Fixes

Part of UserOfficeProject/issue-tracker#239

Changes

Depends on

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@voduguwa voduguwa added the review: please A request for an ad-hoc review. label Sep 8, 2022
@voduguwa voduguwa requested review from a team and ACLay and removed request for a team September 8, 2022 16:42
@voduguwa voduguwa removed the review: please A request for an ad-hoc review. label Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants