Skip to content
This repository was archived by the owner on Oct 20, 2022. It is now read-only.

Conversation

@voduguwa
Copy link
Contributor

@voduguwa voduguwa commented Aug 16, 2022

Description

Make the publication title field multiline to accommodate for longer titles.

Motivation and Context

The field accepts 500 characters, so increasing the character limit was not necessary. Longer titles can fit into the text field by being typed on multiple lines.

How Has This Been Tested

Ensured that you could type the title on multiple lines.

Fixes

Part of UserOfficeProject/issue-tracker#239

Changes

Depends on

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@voduguwa voduguwa added the review: please A request for an ad-hoc review. label Aug 16, 2022
Copy link
Contributor

@simonfernandes simonfernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we allow that many characters, I think it would be good to truncate the display of the title too. Maybe past a certain number of characters it can append ellipses?

image

@voduguwa voduguwa removed the review: please A request for an ad-hoc review. label Aug 16, 2022
@voduguwa
Copy link
Contributor Author

Git issues causing build to fail, so another request has been opened: #1003

@voduguwa voduguwa closed this Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants