From 7392f30a73540393434c6f03fed993334b65e17e Mon Sep 17 00:00:00 2001 From: Max Brokman Date: Tue, 19 Nov 2024 16:01:36 +0000 Subject: [PATCH] fix: Soft deleted waiting lists would crash waiting list retrieval (#3880) --- app/Models/Mship/Concerns/HasWaitingLists.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/Models/Mship/Concerns/HasWaitingLists.php b/app/Models/Mship/Concerns/HasWaitingLists.php index 62bfca451..3ab1be051 100644 --- a/app/Models/Mship/Concerns/HasWaitingLists.php +++ b/app/Models/Mship/Concerns/HasWaitingLists.php @@ -45,6 +45,12 @@ public function currentWaitingLists(): Collection $waitingLists = collect(); foreach ($waitingListAccounts as $waitingListAccount) { $waitingList = $waitingListAccount->waitingList; + + if (empty($waitingList)) { + // Waiting list has likely been soft deleted, we don't want to retrieve it here + continue; + } + $waitingLists->put($waitingList->id, $waitingList); }