Plugin error logging #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalumTowers
requested changes
Jan 28, 2019
| ); | ||
|
|
||
| Event::fire(new PluginErrorReceivedEvent($pluginError)); | ||
| return response('', 204); |
There was a problem hiding this comment.
Not sure a 204 makes sense? The response should acknowledge the creation of an event (201) or confirm all is okay (200).
| */ | ||
| public function handle(PluginErrorReceivedEvent $errorReceivedEvent) : bool | ||
| { | ||
| Bugsnag::notifyException(new PluginErrorException('New plugin error reported')); |
There was a problem hiding this comment.
This isn't required; Bugsnag will catch any exception that bubbles up to the ExceptionHandler class.
| use App\Events\PluginErrorReceivedEvent; | ||
| use App\Models\PluginError\PluginError; | ||
|
|
||
| class RecordPluginErrorInBugsnagTest extends BaseUnitTestCase |
There was a problem hiding this comment.
I'm not sure this test class has much value?
There was a problem hiding this comment.
I'm a stickler for high test coverage, that's why it exists xD
There was a problem hiding this comment.
If my Bugsnag comment above is addressed it should make this test (and the event) redundant
|
As discussed, we'll likely need to flesh this out a tad more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #18
Allows the plugin to post us JSON data regarding its state, so that we have debugging information.