Fixes #911 - Set VCCS PTT and audio device via LogonDetails.exe #912
Conversation
|
As per advice from Patrick, there are some modules that aren't a standard part of Python. Shall fix :) |
| # VCCS PTT Key | ||
|
|
||
| print("Push a key you want to use for VCCS. (Note: Keyboard only)") | ||
| PTT = str(int(hex(keyboard.read_event().scan_code), 16) << 16) |
There was a problem hiding this comment.
The keybind prompt character may be transferred to the next prompt as input.
| # VCCS PTT Key | ||
|
|
||
| print("Push a key you want to use for VCCS. (Note: Keyboard only)") | ||
| PTT = str(int(hex(keyboard.read_event().scan_code), 16) << 16) |
There was a problem hiding this comment.
Missed this in my cursory look over earlier; what's the purpose of this? Is int(hex(_), 16) not identity?
| VCCSInput = sd.query_devices(sd.default.device[0])['name'] | ||
| VCCSOutput = sd.query_devices(sd.default.device[1])['name'] |
There was a problem hiding this comment.
This doesn't provide any protection against 'abridged' names being the default device, e.g. in my case, my default device is Headset Microphone (2- Corsair rather than the full Headset Earphone (2- Corsair HS70 Wireless Gaming Headset) as saved in ES .prf files. Do we need a warning/prohibition of this? I wonder if it might make more sense to force people to choose their device from a valid list??
There was a problem hiding this comment.
I don't know if this is problematic, but I get twice as many device options in the script as I do running from ES's VCCS Setup. I can imagine it being unhappy if you chose a device which it didn't have in its list?
| PrfVCCSNick=("TeamSpeakVccs Ts3NickName "+CID) | ||
| PrfVCCSPTT=("TeamSpeakVccs Ts3G2GPtt "+PTT) | ||
| PrfVCCSInput=("TeamSpeakVccs CaptureDevice "+VCCSInput) | ||
| PrfVCCSOutput=("TeamSpeakVccs PlaybackDevice "+VCCSOutput) |
There was a problem hiding this comment.
Should we be considering setting the TeamSpeakVccs CaptureMode as well for completeness or does it not matter/default to something sensible?
|
Probably also worth renaming the file to something like "Profile Configurator". |
Yeah. Also, given this .exe is going to be used by new people and observers, should we be explaining more explicitly what VCCS is? Something like: "VCCS is used for voice coordination within EuroScope."... We could maybe even allow users to skip the configuration of it if they wish, but I think 'making' everyone set it up is good personally. |
|
Sorry about the delays everyone! Been busy with work and trying to get FS 2024 working. |
Fixes #911
Summary of changes
Updated LogonDetails.exe to now set up VCCS PTT and audio devices.
Screenshots (if necessary)
N/A