Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban word window + document from @ud-viz/browser #560

Open
valentinMachado opened this issue Mar 10, 2023 · 1 comment
Open

Ban word window + document from @ud-viz/browser #560

valentinMachado opened this issue Mar 10, 2023 · 1 comment
Labels
clean up Code has to be modifed but not functionally priority-medium @ud-viz/smdb

Comments

@valentinMachado
Copy link
Contributor

valentinMachado commented Mar 10, 2023

Since word window is a native word in web API it should be not used in sources.

And to avoid line like this one:

window.window.addEventListener('mousedown', () => {

where none of the window are the actual global variable window...

This imply a lot of renaming

same could be consider for document

@valentinMachado valentinMachado added clean up Code has to be modifed but not functionally @ud-viz/browser labels Mar 10, 2023
@valentinMachado valentinMachado changed the title Ban word window from @ud-viz/browser Ban word window + document from @ud-viz/browser Mar 21, 2023
@valentinMachado
Copy link
Contributor Author

valentinMachado commented Mar 21, 2023

document could be name media since it's working with a backend naming spatial multimedia

EDIT: note that the document part of ud-viz should migrate at some point see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Code has to be modifed but not functionally priority-medium @ud-viz/smdb
Projects
None yet
Development

No branches or pull requests

1 participant