Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImmutableResultSet check .get_data() #177

Open
AlexDo1 opened this issue Jul 7, 2022 · 1 comment
Open

ImmutableResultSet check .get_data() #177

AlexDo1 opened this issue Jul 7, 2022 · 1 comment
Assignees
Labels
bug Something isn't working priority low

Comments

@AlexDo1
Copy link
Collaborator

AlexDo1 commented Jul 7, 2022

We should check (and test) the get_data() method of class ImmutableResultSet.
Sometimes data is not merged correctly, I'm not sure why that is the case (it seems to work for LUBW and Eddy Covariance data).
Duplicate column names seem to be a problem (data coming from result set test:)
Bildschirmfoto 2022-07-07 um 17 12 04

This is the .get_data() method:

def get_data(self, verbose=False, merge=False, **kwargs) -> dict:
"""
Return the data as a checksum indexed dict
"""

get_data() does not always return a dictionary!
The method could also get a harmonize parameter with the same functionality as discussed in #160.

@AlexDo1 AlexDo1 added bug Something isn't working discussion Needs discussion before labeling the issue labels Jul 7, 2022
@mmaelicke
Copy link
Member

@AlexDo1, did we solve this along the way?

@mmaelicke mmaelicke added priority low and removed discussion Needs discussion before labeling the issue labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority low
Projects
None yet
Development

No branches or pull requests

2 participants