Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fake realtime weather #8

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Conversation

jneschisi
Copy link
Contributor

Description

Updated WeatherCard to consume data from the WeatherRepository and update the UI when weather information changes.

Note: in video below weather changes fast for demo purposes, the implementation sets a 60 to 75 seconds interval between updates.

Screen.Recording.2024-07-30.at.10.00.07.AM.mov
Screenshot 2024-07-30 at 10 00 51 AM Screenshot 2024-07-30 at 10 00 57 AM

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jneschisi jneschisi self-assigned this Jul 30, 2024
lib/overview/view/overview_page.dart Outdated Show resolved Hide resolved
@jneschisi jneschisi requested a review from marwfair July 30, 2024 15:59
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Just left a few items of feedback.

lib/weather/view/weather_card.dart Outdated Show resolved Hide resolved
lib/weather/view/weather_card.dart Outdated Show resolved Hide resolved
lib/weather/view/weather_card.dart Outdated Show resolved Hide resolved
lib/weather/cubit/weather_cubit.dart Outdated Show resolved Hide resolved
lib/weather/view/weather_card.dart Outdated Show resolved Hide resolved
@jneschisi jneschisi requested a review from marwfair July 31, 2024 12:30
Base automatically changed from feat/weather-repository to main July 31, 2024 13:49
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jneschisi jneschisi merged commit cb50df3 into main Aug 1, 2024
5 checks passed
@jneschisi jneschisi deleted the feat/fake-realtime-weather branch August 1, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants