feat: move icons to use fontSize
#257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedorov-xyz
reviewed
Aug 10, 2022
| const reactify = (symbol, componentName) => { | ||
| const width = symbol.viewBox.split(' ')[2]; | ||
| const height = symbol.viewBox.split(' ')[3]; | ||
| const defaultWidth = Number(symbol.viewBox.split(' ')[2]); |
There was a problem hiding this comment.
Я бы предложил оперировать термином не default, а viewBoxWidth
There was a problem hiding this comment.
Поправил, спасибо
Приставку relative на fontSize заменил для ясности
👀 Docs deployedSee the docs for this PR at https://vkcom.github.io/icons/pull/257/ |
fedorov-xyz
reviewed
Aug 10, 2022
| * | ||
| * @default берётся максимальная ширина или высота иконки (см. `viewBox`) | ||
| */ | ||
| fontSize?: string | number; |
There was a problem hiding this comment.
Хм, думал об этом, но font-size принимает гораздо больше значений
или думаешь стоит ограничить?
UPD
а, такая типизация не будет покрывать передачу "<number>em", "<number>%" и т.п.
size-limit report 📦
|
inomdzhon
force-pushed
the
issue237-mv-to-use-fontSize
branch
from
f9cf67e to
dd63966
Compare
inomdzhon
force-pushed
the
issue237-mv-to-use-fontSize
branch
from
fa2556e to
51a5d0e
Compare
|
см. #237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Все подробности в issue #237.
Разъяснение решений
Создал внутренние параметры
fontSizeWidth/fontSizeHeight, чтобы высчитывание было один раз вне рантайма (см.pxToEm()в файлеscripts/reactify.js).Создал внутренние параметры
viewBoxWidth/viewBoxHeight, которые всегда числовые и совпадают сviewBox, т.к.width/heightуSvgIconизначально не должны быть определены:fontSizeWidth/fontSizeHeightили нет.classNameна основеviewBoxWidth/viewBoxHeight.Передача
width/heightэти два момента перебьёт.Дополнительно
Поправил в документации заголовок под названием Кастомные размеры
widthиheightна относительные единицы #237