make event list more compact on mobile #82
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| $thumbnailSizeMobile: 75px; | ||
|
|
||
| .next-events-summary, | ||
| .past-events-summary { | ||
| display: grid; | ||
|
|
@@ -15,10 +17,13 @@ | |
| .event-summary { | ||
| position: relative; | ||
| justify-self: left; | ||
| margin-bottom: $space-medium; | ||
| width: 100%; | ||
|
|
||
| @include size-medium { | ||
| width: auto; | ||
| max-width: 300px; | ||
| margin-bottom: $space-large; | ||
| justify-self: center; | ||
| } | ||
|
|
||
|
|
@@ -32,22 +37,36 @@ | |
| text-transform: uppercase; | ||
|
|
||
| .date-badge { | ||
| display: none; | ||
|
|
||
| @include size-medium { | ||
| display: block; | ||
| position: absolute; | ||
| top: 20px; | ||
| right: -10px; | ||
| background-color: $brand-color; | ||
| padding: 0 5px; | ||
| z-index: 1; | ||
|
|
||
| &.invert { | ||
| color: $brand-color; | ||
| background-color: $black; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .reset-link { | ||
| margin-bottom: $space-small; | ||
| background-image: none; | ||
| float: left; | ||
| margin-right: $space-medium; | ||
| max-width: $thumbnailSizeMobile; | ||
|
|
||
| @include size-medium { | ||
| float: none; | ||
| margin-right: 0; | ||
| max-width: auto; | ||
| } | ||
|
|
||
| &:hover { | ||
| background-image: none; | ||
|
|
@@ -57,13 +76,15 @@ | |
|
|
||
| img { | ||
| width: 100%; | ||
| min-width: 50px; | ||
| outline: 4px solid $black; | ||
| border-radius: 50%; | ||
|
|
||
| background-color: whitesmoke; | ||
| transition: outline 120ms ease-in-out; | ||
|
|
||
| @include size-medium { | ||
| max-width: 300px; | ||
| width: 300px; | ||
| height: 300px; | ||
| } | ||
|
|
@@ -77,13 +98,22 @@ | |
| text-align: left; | ||
| color: $text-color-secondary; | ||
| font-size: 0.9rem; | ||
| margin-left: $thumbnailSizeMobile; | ||
|
There was a problem hiding this comment. I hope that with flex/grid instead of float this margin-left is not needed. But if it is truly needed, could you move it to https://github.com/VLCTechHub/VLCTechHub-site/blob/master/data/assets/css/abstract/_variables.scss in kebab-case? There was a problem hiding this comment. I'll take a look as soon as the float issue is resolved |
||
| padding-left: $space-medium; | ||
| @include size-medium { | ||
| margin-left: 0; | ||
| padding-left: 0; | ||
| } | ||
| } | ||
|
|
||
| hr { | ||
| width: 30%; | ||
| height: 2px; | ||
| color: black; | ||
| background-color: black; | ||
| margin: $space-medium auto $space-large auto; | ||
| @include size-medium { | ||
| margin: $space-large auto $space-larger auto; | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you use flex instead of float?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll work on that this week. I think because of the nesting,
floatwas the easier solution, but I'll see if we can use flexbox instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I can't get this done easily because I'd need to change the HTML structure. Right now, I don't have lots of time, so I don't think it'll be possible in the next 1-2 weeks.