Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

モデルの読み込みを起動時から変更 #400

Merged
merged 9 commits into from
May 15, 2022

Conversation

takana-v
Copy link
Member

@takana-v takana-v commented May 12, 2022

内容

題の通り

関連 Issue

close #394

スクリーンショット・動画など

その他

まだ動作未確認です。
Windows環境で動作確認済です。

@github-actions
Copy link

github-actions bot commented May 12, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 40 4 coverage-90%
voicevox_engine/experimental/init.py 0 0 coverage-100%
voicevox_engine/experimental/guided_extractor.py 128 94 coverage-27%
voicevox_engine/experimental/julius4seg/init.py 0 0 coverage-100%
voicevox_engine/experimental/julius4seg/converter.py 298 295 coverage-1%
voicevox_engine/experimental/julius4seg/sp_inserter.py 116 89 coverage-23%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 147 7 coverage-95%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 198 159 coverage-20%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 48 39 coverage-19%
voicevox_engine/synthesis_engine/synthesis_engine.py 194 74 coverage-62%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 68 9 coverage-87%
voicevox_engine/user_dict.py 107 10 coverage-91%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
voicevox_engine/utility/engine_root.py 9 2 coverage-78%
TOTAL 1780 790 coverage-56%

@Hiroshiba
Copy link
Member

こちら実はもうレビュー可能だったりされますか?👀

@takana-v
Copy link
Member Author

#401 (comment)
こちらの問題があったのでテストできていません。
#401 のマージ後にお願いします。

Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実装自体は全く問題なさそうでした! ただ、コアの API に渡す引数の型に関してちょっと問題意識・提案を持ったのでコメントしました(もし意図があって現在の型が選択されている場合はスルーしていただければと思います)。

voicevox_engine/synthesis_engine/core_wrapper.py Outdated Show resolved Hide resolved
Co-authored-by: Gray Suitcase <[email protected]>
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、引数の型に関して指摘漏れがあったので、確認いただければ幸いです。

voicevox_engine/synthesis_engine/core_wrapper.py Outdated Show resolved Hide resolved
voicevox_engine/synthesis_engine/core_wrapper.py Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

必要なキャラクターだけ読み込むようにする
3 participants