-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
モデルの読み込みを起動時から変更 #400
モデルの読み込みを起動時から変更 #400
Conversation
こちら実はもうレビュー可能だったりされますか?👀 |
#401 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
実装自体は全く問題なさそうでした! ただ、コアの API に渡す引数の型に関してちょっと問題意識・提案を持ったのでコメントしました(もし意図があって現在の型が選択されている場合はスルーしていただければと思います)。
Co-authored-by: Gray Suitcase <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
すみません、引数の型に関して指摘漏れがあったので、確認いただければ幸いです。
Co-authored-by: Gray Suitcase <[email protected]>
Co-authored-by: Gray Suitcase <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
内容
題の通り
関連 Issue
close #394
スクリーンショット・動画など
その他
まだ動作未確認です。Windows環境で動作確認済です。