Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all the models to a separate folder #97

Closed
Maheen-Ilyas opened this issue May 18, 2024 · 6 comments
Closed

Move all the models to a separate folder #97

Maheen-Ilyas opened this issue May 18, 2024 · 6 comments
Assignees
Labels
gssoc Girl Script Summer of Code level2 Medium to solve issues for GSSoC'24

Comments

@Maheen-Ilyas
Copy link
Contributor

As the number of modules in the application are increasing, the model classes for the each module will also increase. We can create a models folder and move all the models into that folder. This will make the codebase clean and in the future, the contributors can make changes if needed with ease.

I am GSSoC'24 contributor. Please consider this.

@sapatevaibhav sapatevaibhav added gssoc Girl Script Summer of Code level2 Medium to solve issues for GSSoC'24 labels May 18, 2024
@xkaper001
Copy link
Contributor

Hi Contributors and Mentors, I have already worked upon this issue and made a PR regarding this in #83 (merged already)
Furthur

  • All the models have been moved to a module folder making the codebase cleaner.

Hey @sapatevaibhav could you assign me and close this issue as completed.

@Maheen-Ilyas
Copy link
Contributor Author

This issue is regarding these classes.
class Bird {
final String name;
final String svgAsset;
final String soundAsset;
final Color backgroundColor;

Bird({
required this.name,
required this.svgAsset,
required this.soundAsset,
required this.backgroundColor,
});
}

@xkaper001
Copy link
Contributor

This issue is regarding these classes. class Bird { final String name; final String svgAsset; final String soundAsset; final Color backgroundColor;

Bird({ required this.name, required this.svgAsset, required this.soundAsset, required this.backgroundColor, }); }

could you elaborate

@Maheen-Ilyas
Copy link
Contributor Author

This issue is regarding these classes. class Bird { final String name; final String svgAsset; final String soundAsset; final Color backgroundColor;
Bird({ required this.name, required this.svgAsset, required this.soundAsset, required this.backgroundColor, }); }

could you elaborate

Each module has these classes. We can have a folder called models and move them to a separate file in the folder.

@xkaper001
Copy link
Contributor

xkaper001 commented May 19, 2024

Each module has these classes. We can have a folder called models and move them to a separate file in the folder.

check with the latest commit on master branch. I made a model folder with a module class in it and all the modules are placed in pages/modules (except the new ones being made by other contributors)

@sapatevaibhav
Copy link
Member

#112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girl Script Summer of Code level2 Medium to solve issues for GSSoC'24
Projects
None yet
Development

No branches or pull requests

3 participants