Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to home page. #63

Merged
merged 1 commit into from
May 15, 2024
Merged

Changes to home page. #63

merged 1 commit into from
May 15, 2024

Conversation

xkaper001
Copy link
Contributor

@xkaper001 xkaper001 commented May 13, 2024 •
edited
Loading

Summary

This pull request improves the user navigation by implementing a Bottom navigation bar.

Changes

  • BottomNavBar implemented
  • new explore page for the user
  • new favourite page for modules favourited by the user.

not yet removed the drawer completely as there are things which has to be integrated into the explore and home

Additional Information

This pull request creates more opportunities for the contributors by creating more issues such as #61
This PR also implements

@xkaper001
Copy link
Contributor Author

xkaper001 commented May 13, 2024 •
edited
Loading

Screenshot of the HomePage

Screenshot_2024-05-13-21-35-26-06_6345f10bafcf1bdda7a59f5491e3d26f.jpg

@sapatevaibhav sapatevaibhav requested a review from nehal076 May 14, 2024 13:05
@xkaper001 xkaper001 mentioned this pull request May 14, 2024
Closed
nehal076
nehal076 approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@nehal076 nehal076 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nehal076 nehal076 added gssoc Girl Script Summer of Code level2 Medium to solve issues for GSSoC'24 labels May 15, 2024
@nehal076 nehal076 merged commit 2e9dedc into VaibhavCodeClub:master May 15, 2024
@xkaper001
Copy link
Contributor Author

hey @sapatevaibhav @nehal076 Can you also close this as completed the #60 as it also has been solved under this PR as stated above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nehal076 nehal076 nehal076 approved these changes

Assignees
No one assigned
Labels
gssoc Girl Script Summer of Code level2 Medium to solve issues for GSSoC'24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xkaper001 @nehal076