Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthesize root watch directories from queries on init #10

Open
ValdemarGr opened this issue Dec 3, 2023 · 1 comment
Open

Synthesize root watch directories from queries on init #10

ValdemarGr opened this issue Dec 3, 2023 · 1 comment

Comments

@ValdemarGr
Copy link
Owner

ValdemarGr commented Dec 3, 2023

Every change rooted in the workspace (but not bazel*) should probably be watched? Maybe this is parameterizable?

@ValdemarGr
Copy link
Owner Author

ValdemarGr commented Dec 6, 2023

I have added a --watch parameter for now.

I don't think local_repository type of rules are harder than the current workspace.

Maybe just watch all
$$\texttt{local-repositories} \cup \texttt{current-workspace} \backslash \set{\texttt{bazel-bin}, \texttt{bazel-out}, \texttt{bazel-testlogs}, \texttt{bazel-current-workspace}}$$
ibazel also watches every change ibazel only reacts to changes in the build graph, which means that dynamically expanded functions such as glob are not respected; it seems to be a difficult task to precisely watch all the correct locations. For new build target creation I don't see how you can construct an algorithm that catches such events without watching everything.

I think skipping creations will be bad DX. So maybe add flags for controlling the watching config (explicitly add/omit paths).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant