New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tensor::slice(std::initializer_list<range1d<U>> ) is broken now #69

Open

shengg opened this issue Aug 5, 2014 · 1 comment

Labels

bug

Contributor

shengg commented Aug 5, 2014

Tensor::slice() is broken, because it uses Tensorview constructor. However, explicit Tensorview(range_type&&, storage_type&) is private.

Since there is make_view(), maybe Tensor::slice is not useful now.

shengg added the bug label

Contributor

shiozaki commented Aug 5, 2014

It's not clear to me if this function should return make_tensor or make_rwtensor. Maybe better to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment