Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsync: Fix checking if futex_waitv is available. #256

Open
wants to merge 301 commits into
base: bleeding-edge
Choose a base branch
from
Open

fsync: Fix checking if futex_waitv is available. #256

wants to merge 301 commits into from

Conversation

mati7337
Copy link

Proton's wine checks if futex_waitv syscall is available by checking if it sets errno to ENOSYS.
This works in most cases, however in environments like podman even though this syscall is blocked it sets errno to EPERM instead which causes fsync to be enabled despite it not being supported. This causes 100% CPU usage even when launching notepad.exe.

In podman this seems to be a problem since containers/common@a3f335c which added futex_waitv to the seccomp blocklist. It seems that before that commit it returned ENOSYS which wine correctly recognized as unsupported.

This PR fixes this by additionally checking if errno isn't EPERM before enabling fsync.

@rbernon
mfplat/tests: Add tests for MFInitMediaTypeFromMFVideoFormat.
f04fa2f 
(cherry picked from commit 899abea)

CW-Bug-Id: #20833
@rbernon
mfplat/mediatype: Implement MFInitMediaTypeFromMFVideoFormat.
712af78 
(cherry picked from commit eac5ad2)

CW-Bug-Id: #20833
@rbernon
mfplat/tests: Add some broken results for Win7.
94c7eee 
(cherry picked from commit 2734b26)

CW-Bug-Id: #20833
@rbernon
mfplat/tests: Test initializing mediatype from AAC WAVEFORMATEXTENSIBLE.
75d8696 
(cherry picked from commit 3593ce0)

CW-Bug-Id: #20833
@rbernon
mfplat/tests: Check how AAC attributes are copied from user data.
235774b 
(cherry picked from commit 9ee0720)

CW-Bug-Id: #20833
@rbernon
mfplat/mediatype: Check format pointers and sizes in MFInitMediaTypeF…
5547d5f 
…romAMMediaType.

(cherry picked from commit 45d4aa9)

CW-Bug-Id: #20833
@rbernon
mfplat/mediatype: Support audio major type in MFInitMediaTypeFromAMMe…
94b4683 
…diaType.

(cherry picked from commit 689868c)

CW-Bug-Id: #20833
@rbernon
mfplat/mediatype: Force WAVEFORMATEXTENSIBLE in MFCreateWaveFormatExF…
ceabceb 
…romMFMediaType in some cases.

(cherry picked from commit a4fb357)

CW-Bug-Id: #20833
@rbernon
mfplat/mediatype: Implement MFCreateMediaTypeFromRepresentation.
e3e5088 
(cherry picked from commit 1e05381)

CW-Bug-Id: #20833
@rbernon
mfplat/mediatype: Use MFCreateWaveFormatExFromMFMediaType in init_am_…
5dbac07 
…media_type_audio_format.

(cherry picked from commit 552cec9)

CW-Bug-Id: #20833
@rbernon
mf/tests: Check that pan scan and geometric apertures are set.
6515aa1 
(cherry picked from commit da2c20a)

CW-Bug-Id: #20833
@rbernon
evr/tests: Split create_d3d_sample to a separate helper.
b37c592 
(cherry picked from commit 1f589f6)

CW-Bug-Id: #20833
@rbernon
evr/tests: Split check_presenter_output to a separate helper.
6d0b2bc 
(cherry picked from commit c5f0039)

CW-Bug-Id: #20833
@rbernon
evr/tests: Add more video mixer input media type aperture tests.
44a41f2 
(cherry picked from commit d304e58)

CW-Bug-Id: #20833
@rbernon
evr/mixer: Respect input media type MF_MT_GEOMETRIC_APERTURE.
0cb9fe1 
(cherry picked from commit b1cca5b)

CW-Bug-Id: #20833
@rbernon
mf/session: Avoid leaking samples in transform_node_deliver_samples.
b11b7e9 
(cherry picked from commit 593dcb1)

CW-Bug-Id: #20833
@rbernon
mfplat: Append MFVIDEOFORMAT user data after the structure padding.
d44d7c0 
Instead of using the last palette entry, which might be misaligned.

(cherry picked from commit 26876b4)

CW-Bug-Id: #20833
@rbernon
mfmediaengine/tests: Test that effects allow converters between them.
470417a 
(cherry picked from commit a9871e4)

CW-Bug-Id: #20833
@rbernon
mfmediaengine: Allow decoder / converter to be resolved between topol…
56dd79c 
…ogy nodes.

(cherry picked from commit fa23650)

CW-Bug-Id: #20833
@rbernon
mfplat: Fix MFCreateMFVideoFormatFromMFMediaType videoInfo.VideoFlags…
89eb2df 
… masks.

(cherry picked from commit 551d047)

CW-Bug-Id: #20833
@rbernon
mfplat: Use IMFMediaType_GetBlobSize instead of IMFMediaType_GetBlob.
149ee54 
(cherry picked from commit 3404de3)

CW-Bug-Id: #20833
@rbernon
mfplat: Introduce a new init_video_info_header helper.
bce45ac 
(cherry picked from commit 704c510)

CW-Bug-Id: #20833
@rbernon
mfplat: Use media_type_get_uint32 in more places.
87e6f70 
(cherry picked from commit 00758a2)

CW-Bug-Id: #20833
@rbernon
mfplat: Factor AM_MEDIA_TYPE video format allocation.
b4fa580 
(cherry picked from commit 772ad6e)

CW-Bug-Id: #20833
@rbernon
mfplat: Set AM_MEDIA_TYPE bTemporalCompression and bFixedSizeSamples.
27a5995 
(cherry picked from commit 0b5c04c)

CW-Bug-Id: #20833
@rbernon
mfplat: Implement FORMAT_MPEGVideo for MFInitAMMediaTypeFromMFMediaType.
8d1bc0f 
(cherry picked from commit dce8d8b)

CW-Bug-Id: #20833
@rbernon
mfplat: Implement FORMAT_MPEG2Video for MFInitAMMediaTypeFromMFMediaT…
7b5343d 
…ype.

(cherry picked from commit ec0455b)

CW-Bug-Id: #20833
@rbernon
mfplat: Implement MFInitMediaTypeFromMPEG1VideoInfo.
62664c1 
(cherry picked from commit 8c77a1a)

CW-Bug-Id: #20833
@rbernon
mfplat: Implement MFInitMediaTypeFromMPEG2VideoInfo.
73433f5 
(cherry picked from commit 9fac589)

CW-Bug-Id: #20833
@rbernon
mfplat: Implement MFCreateVideoMediaType.
29da157 
(cherry picked from commit bf64ae2)

CW-Bug-Id: #20833
rbernon and others added 29 commits September 5, 2024 15:46
@rbernon
winegstreamer: Generate timestamps relative to the first input sample.
d74d968 
CW-Bug-Id: #20833
@rbernon
winegstreamer/new_media_source: Snap seek to the previous keyframe.
fa463d5 
CW-Bug-Id: #20833
@rbernon
winegstreamer/audio_decoder: Fill output block align and bytes per se…
c529a9d 
…cond if not set.

CW-Bug-Id: #20833
@rbernon
mfmediaengine: Ignore MEEndOfPresentation for the video frame sink.
2a1ea69 
This is an indication that the source has ended, and that the session is
about to end, but not that all the samples in the session have been
decoded and processed.

CW-Bug-Id: #20833

CW-Bug-Id: #20833
@rbernon
mfmediaengine: Implement D3D-aware video frame sink.
9e28492 
CW-Bug-Id: #20833

CW-Bug-Id: #20833
@rbernon
winegstreamer: Continue autoplugging after protonvideoconverter eleme…
a609b66 
…nts.

CW-Bug-Id: #20833
@ziqingh @rbernon
winegstreamer/wg_parser: HACK: Return untranscoded codec format for t…
65c8ec0 
…ranscoded stream.

CW-Bug-Id: #21303
CW-Bug-Id: #22008

CW-Bug-Id: #20833
@ziqingh @rbernon
winegstreamer/video_decoder: HACK: Try use I420 input if failed to cr…
9269e1f 
…eate transform.

CW-Bug-Id: #21303
CW-Bug-Id: #23630

CW-Bug-Id: #20833
@rbernon
winegstreamer: Check and use embedded caps in codec data.
98b8f9d 
CW-Bug-Id: #20833
@rbernon
winegstreamer: Use H264 GUID when converting caps to video format.
96dc38a 
CW-Bug-Id: #20833
@rbernon
winegstreamer/media-converter: Avoid leaking lock when dumping is int…
4c9b4ad 
…errupted.

CW-Bug-Id: #20833
@rbernon
winegstreamer/video_decoder: Register the generic video decoder with …
8ce06ad 
…more formats.

Fixes missing video in Devil May Cry HD Collection / DMC1.

CW-Bug-Id: #20833
@rbernon
winegstreamer/new_media_source: Flush queued samples on flush-stop.
f60fb2e 
Fixes garbled first frame in ARK: Survival Evolved.

CW-Bug-Id: #20833
@rbernon
mfplat: Flush D3D11 context after CopySubresourceRegion on unmap.
868104d 
Fixes some garbled video frames when the texture is later used as input
by the video processor.

CW-Bug-Id: #20833
@rbernon
winegstreamer: Remove 'au' alignment for h264.
add4e83 
h264parse does not correctly determine 'nal' alignment if this caps is
provided.

CW-Bug-Id: #23226
CW-Bug-Id: #23425
@rbernon
winegstreamer: Use "avc" H264 stream format when "codec_data" is prov…
a5090ea 
…ided.

CW-Bug-Id: #20833
@rbernon
mfreadwrite: Always try inserting a converter for non-video streams.
5f18014 
CW-Bug-Id: #20833
@Etaash-mathamsetty @rbernon
mmdevapi: Support getting IAudioClockAdjustment interface.
e701f26 
For 4K cutscenes in Ghostbusters: The Video Game Remastered

Link: ValveSoftware#245
@rbernon
winegstreamer: Avoid using the aperture for padding with the H264 dec…
bc73118 
…oder.

It can change stream sizes during playback, and the video info aren't
updated accordingly.

CW-Bug-Id: #20833
@rbernon
winegstreamer/resampler: Use WAVEFORMATEX for input/output media types.
84c56e5 
CW-Bug-Id: #20833
@rbernon
winegstreamer/resampler: Recalculate resampler nBlockAlign and avgByt…
f3697ea 
…esPerSec values.

CW-Bug-Id: #20833
@rbernon
Revert "HACK: mmdevapi: Disable getting IAudioClockAdjustment via Get…
c1885c7 
…Service."

This reverts commit 8c9e894.
@rbernon
Revert "mmdevapi: Support getting IAudioClockAdjustment interface."
de88957 
This reverts commit e701f26.
ntdll: Allow sending to port 0 on UDP socket to succeed.
07194e8 
CW-Bug-Id: #24213
winegstreamer: Allow application to drain queue.
edb8528 
Pushing all queued input immediately causes gstreamer to process all
frames in advance and queue them in the output_queue of the transform.

This results in a large amount of memory usage that can cause an OOM
issue.

This patch allows the queue to be drained at the rate required by the
application.

(cherry picked from commit 4a6c1c1)

CW-Bug-Id: #24132
@w-flo
include: Add TCP_KEEPCNT and TCP_KEEPINTVL definitions.
bda0dc2 
(cherry picked from commit 6d2a900)

CW-Bug-Id: #24237
@w-flo
ws2_32/tests: Test TCP_KEEP{ALIVE,CNT,INTVL} options.
c797df3 
(cherry picked from commit 26136fd)

CW-Bug-Id: #24237
@w-flo
ws2_32: Implement TCP_KEEP{ALIVE,CNT,INTVL} options.
243b2b4 
(cherry picked from commit 8dc5242)

CW-Bug-Id: #24237
@mati7337
fsync: Fix checking if futex_waitv is available.
b6335b4 
Check for EPERM in addition to ENOSYS when checking futex_waitv's
availability. EPERM is returned in environments where the futex_waitv
syscall is blocked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mati7337 @rbernon @ziqingh @baskanov @zzhiyi @Alcaro @ivyl @Etaash-mathamsetty @w-flo