Estelle/test meta analysis #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencap
approved these changes
Dec 10, 2024
| assert score_set_1_refresh["metaAnalyzedByScoreSetUrns"] == [meta_score_set["urn"]] | ||
|
|
||
| meta_score_set = (client.post(f"/api/v1/score-sets/{meta_score_set['urn']}/publish")).json() | ||
| assert meta_score_set["urn"] == "urn:mavedb:00000001-0-1" |
There was a problem hiding this comment.
In so far as we check the URNs of test objects, I think we only need to check that the URN matches the URN RegEx.
There was a problem hiding this comment.
I added the RegEx checks to all meta-analysis tests, but I support keeping them cause the meta-analysis urn is more special. This way is more accurate. RegEx only confirms they match the basic rules, but can't make sure the middle one is number 0 or letters.
| assert score_set_1_refresh["metaAnalyzedByScoreSetUrns"] == [meta_score_set["urn"]] | ||
|
|
||
| meta_score_set = (client.post(f"/api/v1/score-sets/{meta_score_set['urn']}/publish")).json() | ||
| assert meta_score_set["urn"] == "urn:mavedb:00000003-0-1" |
There was a problem hiding this comment.
Same RegEx comment as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some more basic test cases of meta analysis. Nearly the same as before, but changing the score set's creators.