Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak behavior of superseding score sets for users without permissions #371

Open
bencap opened this issue Dec 17, 2024 · 1 comment · May be fixed by #366
Open

Tweak behavior of superseding score sets for users without permissions #371

bencap opened this issue Dec 17, 2024 · 1 comment · May be fixed by #366
Assignees
Labels
app: backend Task implementation touches the backend type: bug Something isn't working

Comments

@bencap
Copy link
Collaborator

bencap commented Dec 17, 2024

A superseding score set should only count as superseding if a user has view+ permissions on it. Otherwise, they should still see the most up to date score set which they have permissions for.

See: https://github.com/search?q=repo%3AVariantEffect%2Fmavedb-api%20~ScoreSet.superseding&type=code

@bencap bencap added type: bug Something isn't working app: backend Task implementation touches the backend labels Dec 17, 2024
@EstelleDa EstelleDa linked a pull request Dec 17, 2024 that will close this issue
@EstelleDa EstelleDa self-assigned this Dec 18, 2024
@EstelleDa EstelleDa linked a pull request Dec 20, 2024 that will close this issue
@EstelleDa
Copy link
Member

I'll need more time to think about how to adjust the searching score set function when I'm back. The original requirement is not showing superseded score sets. However, the current codes don't handle a case where a superseding score set has not been published yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: backend Task implementation touches the backend type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants