Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make URN a non-Nullable field #372

Open
bencap opened this issue Dec 19, 2024 · 0 comments
Open

Make URN a non-Nullable field #372

bencap opened this issue Dec 19, 2024 · 0 comments
Labels
app: backend Task implementation touches the backend app: database Task implementation requires database changes type: bug Something isn't working

Comments

@bencap
Copy link
Collaborator

bencap commented Dec 19, 2024

(at least) the score set URN is currently a nullable field, even though it is de-facto required on all DB records. This causes a minor annoyance while type checking, since mypy presumes this field has the potential to by Nonetype.

As part of this fix, we should make sure other URN fields are non-nullable and that any associated type hints are corrected to eliminate the Optional keyword.

@bencap bencap added app: backend Task implementation touches the backend app: database Task implementation requires database changes type: bug Something isn't working labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: backend Task implementation touches the backend app: database Task implementation requires database changes type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant