Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search results overwritten by previous (unfinished) request #157

Open
ashsny opened this issue Apr 9, 2024 · 1 comment
Open

search results overwritten by previous (unfinished) request #157

ashsny opened this issue Apr 9, 2024 · 1 comment
Assignees
Labels
app: frontend Task implementation touches the frontend type: bug Something isn't working

Comments

@ashsny
Copy link
Contributor

ashsny commented Apr 9, 2024

steps to reproduce:

  1. go to search page: https://mavedb.org/#/search (this kicks off a request for everything in the db, which is slow)
  2. enter a simple search that will complete quickly in the field (i.e. '5-a') and hit enter

expected behavior

  1. your (second) search loads

actual behavior

  1. your (second) search loads
  2. the first search (for everything) completes and overwrites the results of your second search
@bencap bencap added the type: bug Something isn't working label Aug 27, 2024
@bencap bencap added the app: frontend Task implementation touches the frontend label Oct 1, 2024
@bencap bencap assigned bencap and nickzoic and unassigned bencap Oct 7, 2024
@nickzoic
Copy link

nickzoic commented Oct 7, 2024

possibly this becomes less annoying about if VariantEffect/mavedb-api#89 gets fixed.

Otherwise it generally just means cancelling the previous search request when the search changes, so the async response doesn't overwrite whereever we're at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: frontend Task implementation touches the frontend type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants