Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate Treatment of NaN Scores in Heatmap #256

Open
bencap opened this issue Aug 26, 2024 · 0 comments
Open

Evaluate Treatment of NaN Scores in Heatmap #256

bencap opened this issue Aug 26, 2024 · 0 comments
Labels
app: frontend Task implementation touches the frontend type: bug Something isn't working type: discussion Team discussion required

Comments

@bencap
Copy link
Collaborator

bencap commented Aug 26, 2024

Currently, if a score set has multiple variants at a locus that evaluate to the same protein to protein change and one (or more) scores are NaN these scores are not considered part of the average.

We should evaluate if this behavior is the desired behavior. Other options might be:

  • Treating all scores at this locus as NaN
  • A different default value for NaN scores
bencap added a commit that referenced this issue Aug 26, 2024
@bencap
Bugfixes for ScoreSet Heatmap
c9fccb8 
Hides Selection Tooltip When No Bin is Selected:

The previous version threw errors when selecting a heatmap square with no score, since this
variant was not present in the histogram.

Treat NaN Scores as Null:

The previous version sent all such score averages to NaN. See #256
for further information.
@bencap bencap added type: discussion Team discussion required type: bug Something isn't working labels Aug 27, 2024
@bencap bencap added the app: frontend Task implementation touches the frontend label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app: frontend Task implementation touches the frontend type: bug Something isn't working type: discussion Team discussion required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bencap