-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not showing meta-analysis experiments in creating score set dropdown menu. #310
base: release-2024.4.4
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My sense with this particular issue is that we should just filter the list of experiments returned to us by the API such that they exclude meta-analysis experiments. That way we don't need to make any API changes. The filter options here are a little wonky, since they don't actually serve any purpose at the moment other than denoting whether to show all experiments or just a user's experiments.
I changed the back-end codes too so that front end excludes the meta-analysis experiment directly. The main filter function is in VariantEffect/mavedb-api#347. |
Yeah I guess that what I'm saying is that either we should make this query field hew closely to the score set structure (passing |
@bencap Sorry, I don't get your means very well or I may misunderstand something. This request is used to up an experiment list. Why do we need to make this query field close to a score set structure for the experiment request? Do you mean I had better change the query to such as |
No description provided.