Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angle<> needs alternative representation control #15

Open
FrancoisChabot opened this issue Sep 3, 2018 · 0 comments
Open

Angle<> needs alternative representation control #15

FrancoisChabot opened this issue Sep 3, 2018 · 0 comments
Labels
enhancement New feature or request low priority Not something that needs to be addressed immediately

Comments

@FrancoisChabot
Copy link
Member

Right now, Angle<>'s internal representation is fixed to be ]-pi.pi]. But that's not great because:

  • It only works with floating point storage
  • There is a fair bit of wasted bits.

I could easily see something like:

using Angle = vecpp::Angle<Fixed_point_representation<std::int16_t>;

Coming in handy.

However, while this is a nice to have, it's a LOT of work that addresses no particular imediate need.

One thing we could seriously consider is modifying the user-facing API immediately to reflect this so that the eventual introduction of alternate angle internal representations does not induce a breaking change.

@FrancoisChabot FrancoisChabot added enhancement New feature or request low priority Not something that needs to be addressed immediately labels Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Not something that needs to be addressed immediately
Projects
None yet
Development

No branches or pull requests

1 participant