Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a size_t count argument to some BNCustomArchitecture.free* fields #5655

Closed
mkrasnitski opened this issue Jun 23, 2024 · 2 comments
Closed

Add a size_t count argument to some BNCustomArchitecture.free* fields #5655

mkrasnitski opened this issue Jun 23, 2024 · 2 comments
Assignees
@emesare
Labels
Component: API Issue needs changes to the API Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps

Comments

@mkrasnitski
Copy link
Contributor

Specifically, the freeFlagConditionsForSemanticFlagGroup and freeRegisterList fields should take an additional size_t count argument so that custom architectures implemented in other languages can correctly free the pointers passed to them through these functions without resorting to hackery (as discussed in #5654).

cc-ing @CouleeApps @KyleMiles
@xusheng6 xusheng6 added Type: Bug Issue is a non-crashing bug with repro steps Component: API Issue needs changes to the API Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day labels Jul 2, 2024
@emesare emesare self-assigned this Jul 29, 2024
@emesare
Copy link
Member

emesare commented Nov 14, 2024 •
edited
Loading

After 4.2 stable this will be added with 4f9ae2f and 67759e6

@emesare
Copy link
Member

emesare commented Dec 14, 2024

Added with b34ddd0 and 121c165.

@emesare emesare closed this as completed Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emesare emesare

Labels
Component: API Issue needs changes to the API Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emesare @mkrasnitski @xusheng6