Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing default text in the "Set Stack Adjustment" dialog #6137

Open
xusheng6 opened this issue Nov 15, 2024 · 0 comments
Open

Confusing default text in the "Set Stack Adjustment" dialog #6137

xusheng6 opened this issue Nov 15, 2024 · 0 comments
Assignees
Milestone

Comments

@xusheng6
Copy link
Member

In the set stack adjustment dialog, when the current address does not have a stack adjustment, the dialog shows the last value from the history ui/stackAdjustSizeHistory. This can be confusing since it can be understood as the current stack adjustment is the value shown, e.g., in the below screenshot, 0x4.

Screenshot 2024-11-15 at 11 46 05 AM

We should probably show it as 0x0 if the stack adjustment is indeed 0x0

@xusheng6 xusheng6 added this to the Gallifrey milestone Nov 15, 2024
@xusheng6 xusheng6 self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant